hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11210) Consider restoring Filter class back to an interface
Date Tue, 20 May 2014 17:16:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003653#comment-14003653
] 

stack commented on HBASE-11210:
-------------------------------

Please fix the description or close.  As is, it makes no sense.

Why does going back to an Interface force use of FilterBase?  Why force use of FilterBase
at all? 

"consider inheriting" does not mean "should override".

> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>
>                 Key: HBASE-11210
>                 URL: https://issues.apache.org/jira/browse/HBASE-11210
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
>  * Interface for row and column filters directly applied within the regionserver.
> ...
>  * When implementing your own filters, consider inheriting {@link FilterBase} to help
>  * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> This gives users / developers clear suggestion that custom filters should override FilterBase
instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message