hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11189) Subprocedure should be marked as complete upon failure
Date Fri, 16 May 2014 11:19:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999693#comment-13999693
] 

Ted Yu commented on HBASE-11189:
--------------------------------

Test failure was not related to the patch. This test sometimes failed in other QA reports
as well. 

Javadoc warnings were not introduced by the patch. 

> Subprocedure should be marked as complete upon failure
> ------------------------------------------------------
>
>                 Key: HBASE-11189
>                 URL: https://issues.apache.org/jira/browse/HBASE-11189
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: 11189-v1.txt
>
>
> ProcedureMember#submitSubprocedure() uses the following check:
> {code}
>       if (!rsub.isComplete()) {
>         LOG.error("Subproc '" + procName + "' is already running. Bailing out");
>         return false;
>       }
> {code}
> If a subprocedure of that name previously ran but failed, its complete field would stay
false, leading to early bailout.
> A failed subprocedure should mark itself complete.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message