hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shengzhe Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11139) BoundedPriorityBlockingQueue#poll() should check the return value from awaitNanos()
Date Sat, 10 May 2014 22:05:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994271#comment-13994271
] 

Shengzhe Yao commented on HBASE-11139:
--------------------------------------

This patch has noting to do with test case: TestMultiParallel which failed due to timeout.
TestMultiParallel passed on my laptop, please let me know if I have to resubmit the patch
or rerun the test.

> BoundedPriorityBlockingQueue#poll() should check the return value from awaitNanos()
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-11139
>                 URL: https://issues.apache.org/jira/browse/HBASE-11139
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Ted Yu
>            Assignee: Shengzhe Yao
>            Priority: Minor
>              Labels: noob
>         Attachments: HBASE-11139-v1.patch, HBASE-11139-v2.patch
>
>
> nanos represents the timeout value.
> {code}
>       while (queue.size() == 0 && nanos > 0) {
>         notEmpty.awaitNanos(nanos);
>       }
> {code}
> The return value from awaitNanos() should be checked - otherwise we may wait for period
longer than the timeout value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message