hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11134) Add a -list-snapshots option to SnapshotInfo
Date Sat, 10 May 2014 21:59:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993951#comment-13993951
] 

Matteo Bertozzi commented on HBASE-11134:
-----------------------------------------

{quote}Binding these vars to FSUtils so they can be picked up later seems strange – can't
this be made more explicit (e.g. when remote is specified we set some vars, if not we load
defaults, and then make the static that lists use those vars){quote}
This isn't specific of list snapshot. this is a quick way to specify a different location.
currently you have to do -Dhbase.root=REMOTE_DIR -Dfs.defaultFS=REMOTE_DIR
I don't want pass around locations all around the code because you may want a different root-dir
than the one that you have in the conf file. It is just an helper. getSnapshotList() is doing
just what is supposed to do, from the configuration that you have specified list the snapshots.


> Add a -list-snapshots option to SnapshotInfo
> --------------------------------------------
>
>                 Key: HBASE-11134
>                 URL: https://issues.apache.org/jira/browse/HBASE-11134
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 0.99.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3
>
>         Attachments: HBASE-11134-v0.patch, HBASE-11134-v1.patch
>
>
> Add a -list-snapshots option to SnapshotInfo to show all the snapshots available. Also
add a -remote-dir option to simplify the usage of SnapshotInfo in case the snapshot dir is
not the one of the current hbase cluster
> {code}
> $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -list-snapshots
> SNAPSHOT             | CREATION TIME        | TABLE NAME
> foo                  |  2014-05-07T22:40:13 | testtb
> bar                  |  2014-05-07T22:40:16 | testtb
> $ hbase org.apache.hadoop.hbase.snapshot.SnapshotInfo -remote-dir file:///backup/ -snapshot
my_local_snapshot
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message