hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11129) Expose Scan conversion methods in TableMapReduceUtil as public methods
Date Sat, 10 May 2014 22:11:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992863#comment-13992863
] 

Nick Dimiduk commented on HBASE-11129:
--------------------------------------

Passing the scanner on the jobconf is a private API, now that the serialization details are
private methods. This implementation detail should be isolated within a single job -- either
it picks up the 0.X.Y hbase-server jar or it has 0.X.Z version, there's no mixing. We'd need
to test it out, but I think making this change could be acceptable for a patch release.

Looking at TableInputFormat#setConf, either "hbase.mapreduce.scan" is respected, or "hbase.mapreduce.scan.*"
params are used. What I propose does away with the former. This way, these configs become
part of the public API.

> Expose Scan conversion methods in TableMapReduceUtil as public methods
> ----------------------------------------------------------------------
>
>                 Key: HBASE-11129
>                 URL: https://issues.apache.org/jira/browse/HBASE-11129
>             Project: HBase
>          Issue Type: Task
>          Components: mapreduce
>            Reporter: Ted Yu
>            Assignee: Gustavo Anatoly
>            Priority: Minor
>         Attachments: HBASE-11129.patch
>
>
> Scan#readFields() from 0.92 has been removed.
> TableMapReduceUtil has the following package private methods:
> {code}
>   static String convertScanToString(Scan scan) throws IOException {
> {code}
> {code}
>   static Scan convertStringToScan(String base64) throws IOException {
> {code}
> We should consider exposing them as public methods so that user can interpret Scan objects
easily in mapreduce jobs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message