hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11109) flush region sequence id may not be larger than all edits flushed
Date Fri, 02 May 2014 23:47:18 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-11109:

    Attachment: 11109v2.txt

Add a test.

Add a bunch of doc on how sequenceid is used.  Removed stale doc (this is why patch is big).

Fix is adding of the sync to push out all edits in the ring buffer.  Comment out the sync
and the test fails.

Removed the below:

-    // sync unflushed WAL changes when deferred log sync is enabled
-    // see HBASE-8208 for details
-    if (wal != null && !shouldSyncLog()) {
-      wal.sync();
-    }

No need of conditional sync now we sync always.

Narrowed the number of references to sequenceId.  Only updated in FSHLog and in internal flush

> flush region sequence id may not be larger than all edits flushed
> -----------------------------------------------------------------
>                 Key: HBASE-11109
>                 URL: https://issues.apache.org/jira/browse/HBASE-11109
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>    Affects Versions: 0.99.0
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.99.0
>         Attachments: 11109.txt, 11109v2.txt
> This was found by [~jeffreyz]  See parent issue.  We have this issue since we put the
ring buffer/disrupter into the WAL (HBASE-10156).
> An edits region sequence id is set only after the edit has traversed the ring buffer.
 Flushing, we just up whatever the current region sequence id is.  Crossing the ring buffer
may take some time and is done by background threads.  The flusher may be taking the region
sequence id though edits have not yet made it across the ringbuffer: i.e. edits that are actually
scoped by the flush may have region sequence ids in excess of that of the flush sequence id
> The consequences are not exactly clear.  Would rather not have to find out so lets fix
this here.

This message was sent by Atlassian JIRA

View raw message