hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11098) Improve documentation around our blockcache options
Date Fri, 02 May 2014 21:28:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988281#comment-13988281
] 

Jonathan Hsieh commented on HBASE-11098:
----------------------------------------

+1 lgtm modulo nits

Wow, this seems kind of complicated
{code}
+  /**
+   * When using bucket cache, this is a float that EITHER represents a percentage of total
heap
+   * memory size to give to the cache (if < 1.0) OR, it is the capacity in megabytes of
the cache.
+   * 
{code}

nit: refernce -> reference
{code}
+  /** Where to send victims (blocks evicted/missing from the cache) */
+  // TODO: Fix it so this is not explicit refernce to a partiular BlockCache implementation.
 {code}

> Improve documentation around our blockcache options
> ---------------------------------------------------
>
>                 Key: HBASE-11098
>                 URL: https://issues.apache.org/jira/browse/HBASE-11098
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: stack
>            Assignee: stack
>         Attachments: 11098.txt, 11098v2.txt
>
>
> Adding as a subtask on [~ndimiduk] necessary cleanup.  Trying to make sense of this stuff
I started adding doc (package-info files, javadoc).  I see this as complementary to the parent
task work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message