hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11092) Server interface should have method getConsensusProvider()
Date Sat, 10 May 2014 22:08:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992477#comment-13992477
] 

Hadoop QA commented on HBASE-11092:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12643858/HBASE_11092.patch
  against trunk revision .
  ATTACHMENT ID: 12643858

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 84 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.hbase.mapreduce.TestImportExport.testImport94Table(TestImportExport.java:230)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9477//console

This message is automatically generated.

> Server interface should have method getConsensusProvider()
> ----------------------------------------------------------
>
>                 Key: HBASE-11092
>                 URL: https://issues.apache.org/jira/browse/HBASE-11092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Consensus
>    Affects Versions: 0.99.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11092.patch, HBASE-11092.patch, HBASE_11092.patch
>
>
> As discussed in comments to HBASE-10915, we need to have a proper way to retrieve instance
of consensus provider, and Server interface seems the right one.
> Since Server interface lives in hbase-client maven module, the following approach is
implemented in this patch:
>  - hbase-client module has very basic (almost marker) interface ConsensusProvider to
return instance of consensus provider from the Server
>  - hbase-server module has BaseConsensusProvider which defines the consensus interfaces
>  - Implementations shall subclass BaseConsensusProvider
>  - whoever wants to get ConsensusProvider from raw Server interface on hbase-server side,
has to typecast: (BaseConsensusProvider) 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message