hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10251) Restore API Compat for PerformanceEvaluation.generateValue()
Date Tue, 13 May 2014 17:14:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996651#comment-13996651
] 

Jean-Daniel Cryans commented on HBASE-10251:
--------------------------------------------

Pass VALUE_LENGTH directly instead of re-declaring it.

> Restore API Compat for PerformanceEvaluation.generateValue()
> ------------------------------------------------------------
>
>                 Key: HBASE-10251
>                 URL: https://issues.apache.org/jira/browse/HBASE-10251
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.98.1, 0.99.0, 0.98.2
>            Reporter: Aleksandr Shulman
>            Assignee: Dima Spivak
>              Labels: api_compatibility
>             Fix For: 0.98.0, 0.98.1, 0.99.0, 0.98.2
>
>         Attachments: HBASE_10251.patch
>
>
> Observed:
> A couple of my client tests fail to compile against trunk because the method PerformanceEvaluation.generateValue
was removed as part of HBASE-8496.
> This is an issue because it was used in a number of places, including unit tests. Since
we did not explicitly label this API as private, it's ambiguous as to whether this could/should
have been used by people writing apps against 0.96. If they used it, then they would be broken
upon upgrade to 0.98 and trunk.
> Potential Solution:
> The method was renamed to generateData, but the logic is still the same. We can reintroduce
it as deprecated in 0.98, as compat shim over generateData. The patch should be a few lines.
We may also consider doing so in trunk, but I'd be just as fine with leaving it out.
> More generally, this raises the question about what other code is in this "grey-area",
where it is public, is used outside of the package, but is not explicitly labeled with an
AudienceInterface.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message