hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10251) Restore API Compat for PerformanceEvaluation.generateValue()
Date Sun, 18 May 2014 16:21:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001115#comment-14001115
] 

Hudson commented on HBASE-10251:
--------------------------------

SUCCESS: Integrated in HBase-0.98 #307 (See [https://builds.apache.org/job/HBase-0.98/307/])
HBASE-10251 Restore API Compat for PerformanceEvaluation.generateValue() (Dima Spivak via
JD) (jdcryans: rev 1594638)
* /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java


> Restore API Compat for PerformanceEvaluation.generateValue()
> ------------------------------------------------------------
>
>                 Key: HBASE-10251
>                 URL: https://issues.apache.org/jira/browse/HBASE-10251
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.98.1, 0.99.0, 0.98.2
>            Reporter: Aleksandr Shulman
>            Assignee: Dima Spivak
>              Labels: api_compatibility
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: HBASE-10251-v2.patch, HBASE_10251.patch, HBASE_10251_v3.patch
>
>
> Observed:
> A couple of my client tests fail to compile against trunk because the method PerformanceEvaluation.generateValue
was removed as part of HBASE-8496.
> This is an issue because it was used in a number of places, including unit tests. Since
we did not explicitly label this API as private, it's ambiguous as to whether this could/should
have been used by people writing apps against 0.96. If they used it, then they would be broken
upon upgrade to 0.98 and trunk.
> Potential Solution:
> The method was renamed to generateData, but the logic is still the same. We can reintroduce
it as deprecated in 0.98, as compat shim over generateData. The patch should be a few lines.
We may also consider doing so in trunk, but I'd be just as fine with leaving it out.
> More generally, this raises the question about what other code is in this "grey-area",
where it is public, is used outside of the package, but is not explicitly labeled with an
AudienceInterface.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message