hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6990) Pretty print TTL
Date Wed, 14 May 2014 17:59:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997829#comment-13997829
] 

Jonathan Hsieh commented on HBASE-6990:
---------------------------------------

Here's the example from the unit test.  Are you looking for more than that [~stack]?

{code}
+  @Test
+  public void testPrettyPrinterTTL() {
+    String out;
+    Long[] values =
+      { 0L, 1L, 1000L, 86400L, 259200L, Long.valueOf(Integer.MAX_VALUE) };
+    String[] messages =
+      { "0 SECONDS", "1 SECOND", "1000 SECONDS", "86400 SECONDS (1 DAY)",
+        "259200 SECONDS (3 DAYS)", "FOREVER" };
+
+    for (int i = 0; i < values.length; i++) {
+      out = PrettyPrinter.format(Long.toString(values[i]), HColumnDescriptor.getUnit(
+          HColumnDescriptor.TTL));
+      assertEquals(
+          String.format(
+              "Expected <%s> ", messages[i]), messages[i], out);
+    }
+  }
{code}


> Pretty print TTL
> ----------------
>
>                 Key: HBASE-6990
>                 URL: https://issues.apache.org/jira/browse/HBASE-6990
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Esteban Gutierrez
>            Priority: Minor
>         Attachments: HBASE-6990.v0.patch, HBASE-6990.v1.patch, HBASE-6990.v2.patch, HBASE-6990.v3.patch
>
>
> I've seen a lot of users getting confused by the TTL configuration and I think that if
we just pretty printed it it would solve most of the issues. For example, let's say a user
wanted to set a TTL of 90 days. That would be 7776000. But let's say that it was typo'd to
77760000 instead, it gives you 900 days!
> So when we print the TTL we could do something like "x days, x hours, x minutes, x seconds
(real_ttl_value)". This would also help people when they use ms instead of seconds as they
would see really big values in there.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message