Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D40B1F77C for ; Mon, 28 Apr 2014 16:26:28 +0000 (UTC) Received: (qmail 16823 invoked by uid 500); 28 Apr 2014 16:26:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16773 invoked by uid 500); 28 Apr 2014 16:26:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16722 invoked by uid 99); 28 Apr 2014 16:26:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 16:26:20 +0000 Date: Mon, 28 Apr 2014 16:26:20 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-11082) Potential unclosed TraceScope in FSHLog#replaceWriter() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-11082: --------------------------------- Affects Version/s: 0.99.0 > Potential unclosed TraceScope in FSHLog#replaceWriter() > ------------------------------------------------------- > > Key: HBASE-11082 > URL: https://issues.apache.org/jira/browse/HBASE-11082 > Project: HBase > Issue Type: Bug > Affects Versions: 0.99.0 > Reporter: Ted Yu > Assignee: Nick Dimiduk > Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-11082.00.patch > > > In the finally block starting at line 924: > {code} > } finally { > // Let the writer thread go regardless, whether error or not. > if (zigzagLatch != null) { > zigzagLatch.releaseSafePoint(); > // It will be null if we failed our wait on safe point above. > if (syncFuture != null) blockOnSync(syncFuture); > } > scope.close(); > {code} > If blockOnSync() throws IOException, the TraceScope would be left unclosed. -- This message was sent by Atlassian JIRA (v6.2#6252)