Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 22 Apr 2014 20:40:17 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12709865.1398199050729.158107.1398199217488@arcas>
In-Reply-To: <JIRA.12709865.1398199050729@arcas>
References: <JIRA.12709865.1398199050729@arcas>
Subject: [jira] [Commented] (HBASE-11051) checkJavacWarnings in
 test-patch.sh should bail out early if there is compilation error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977371#comment-13977371 ] 

Ted Yu commented on HBASE-11051:
--------------------------------

Here is the tail of QA run #9360 :
{code}
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:54.299s
[INFO] Finished at: Tue Apr 22 14:38:04 UTC 2014
[INFO] Final Memory: 49M/531M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java:[28,30] cannot find symbol
[ERROR] symbol  : class HBaseTestingUtility
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java:[30,30] cannot find symbol
[ERROR] symbol  : class MediumTests
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java:[52,22] cannot find symbol
[ERROR] symbol  : class HBaseTestingUtility
[ERROR] location: class org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java:[47,10] cannot find symbol
[ERROR] symbol: class MediumTests
[ERROR] @Category(MediumTests.class)
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java:[52,58] cannot find symbol
[ERROR] symbol  : class HBaseTestingUtility
[ERROR] location: class org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-server
We're ok: there is no zombie test


{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12641244/HBASE-10916.patch
  against trunk revision .
  ATTACHMENT ID: 12641244

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
{code}

> checkJavacWarnings in test-patch.sh should bail out early if there is compilation error
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-11051
>                 URL: https://issues.apache.org/jira/browse/HBASE-11051
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> Currently checkJavacWarnings doesn't exit QA script in the presence of compilation error.
> Here is one example: https://builds.apache.org/job/PreCommit-HBASE-Build/9360/console .
> checkJavacWarnings should do the following so that it is clear what caused the QA run to fail:
> {code}
>   if [[ $? != 0 ]] ; then
>     ERR=`$GREP -A 5 'Compilation failure' $PATCH_DIR/trunkJavacWarnings.txt`
>     echo "Trunk compilation is broken?
>     {code}$ERR{code}"
>     cleanupAndExit 1
>   fi
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)