Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7378811DD2 for ; Wed, 23 Apr 2014 17:19:18 +0000 (UTC) Received: (qmail 86447 invoked by uid 500); 23 Apr 2014 17:19:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 86376 invoked by uid 500); 23 Apr 2014 17:19:17 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86358 invoked by uid 99); 23 Apr 2014 17:19:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Apr 2014 17:19:16 +0000 Date: Wed, 23 Apr 2014 17:19:16 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10970) [AccessController] delete latest version should check covering permission for the latest version only MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978484#comment-13978484 ] Andrew Purtell commented on HBASE-10970: ---------------------------------------- Made another pass over this. Still looks like an improvement so I am still +1. One minor question: {code} + Map familyMap1 = new HashMap(); {code} and below the code only considers List. So why not just use List here? > [AccessController] delete latest version should check covering permission for the latest version only > ------------------------------------------------------------------------------------------------------ > > Key: HBASE-10970 > URL: https://issues.apache.org/jira/browse/HBASE-10970 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: ramkrishna.s.vasudevan > Assignee: Anoop Sam John > Fix For: 0.99.0, 0.98.2 > > Attachments: HBASE-10970.patch, HBASE-10970_V2.patch > > > Refer to discussion in HBASE-10823. > bq.The exact version deletion also check for the preceeding version though the latest version allows the permission -- This message was sent by Atlassian JIRA (v6.2#6252)