Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 23 Apr 2014 07:57:16 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12708182.1397449319651.161594.1398239836125@arcas>
In-Reply-To: <JIRA.12708182.1397449319651@arcas>
References: <JIRA.12708182.1397449319651@arcas>
Subject: [jira] [Commented] (HBASE-10970) [AccessController] delete latest
 version should check covering permission for the latest  version only
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977952#comment-13977952 ] 

ramkrishna.s.vasudevan commented on HBASE-10970:
------------------------------------------------

I went thro the patch.  We will do gets for all the versions in case of Puts and deletes because we are not sure what are the types of deletes inside.
{code}
 if ((col.getQualifierLength() == 0 && request == OpType.DELETE)
                      || CellUtil.matchingQualifier(cell, col)) {
{code}
May be we can refactor this to if/else where if deals with DELETE type and else with Put.  Any way we have considerCellTs which is common in both these cases.  or may be under 
if (consdierCellTs) do the if/else check.
But I still feel atleast for Put doing get with max versions and then checking for the change of col/family is bit overkill when the system has lot of versions.

> [AccessController] delete latest version should check covering permission for the latest  version only
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10970
>                 URL: https://issues.apache.org/jira/browse/HBASE-10970
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-10970.patch
>
>
> Refer to discussion in HBASE-10823.
> bq.The exact version deletion also check for the preceeding version though the latest version allows the permission


--
This message was sent by Atlassian JIRA
(v6.2#6252)