Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 11 Apr 2014 17:20:38 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12707216.1396977606500.101560.1397236838825@arcas>
In-Reply-To: <JIRA.12707216.1396977606500@arcas>
References: <JIRA.12707216.1396977606500@arcas>
Subject: [jira] [Commented] (HBASE-10934) Provide HBaseAdminInterface to
 abstract HBaseAdmin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966821#comment-13966821 ] 

Hadoop QA commented on HBASE-10934:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12639815/HBASE_10934.patch
  against trunk revision .
  ATTACHMENT ID: 12639815

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +   *                                                      threads, the table may have been created between test-for-existence
+   *                                                      threads, the table may have been created between test-for-existence
+   * @throws IllegalArgumentException                     if the table name is reserved, if the split keys
+   *                                                      are repeated and if the split key has empty byte array.
+   *                                                      threads, the table may have been created between test-for-existence
+   *                                                      are repeated and if the split key has empty byte array.
+   *                                                      threads, the table may have been created between test-for-existence
+   *                          <code>TestTable,0094429456,1289497600452.527db22f95c8a9e0116f0cc13c680396.</code>
+   *                          <code>TestTable,0094429456,1289497600452.527db22f95c8a9e0116f0cc13c680396.</code>,
+   *                          then the encoded region name is: <code>527db22f95c8a9e0116f0cc13c680396</code>.

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9257//console

This message is automatically generated.

> Provide HBaseAdminInterface to abstract HBaseAdmin
> --------------------------------------------------
>
>                 Key: HBASE-10934
>                 URL: https://issues.apache.org/jira/browse/HBASE-10934
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Carter
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.99.0
>
>         Attachments: HBASE_10934.patch
>
>
> As HBaseAdmin is essentially the administrative API, it would seem to follow Java best practices to provide an interface to access it instead of requiring applications to use the raw object.
> I am proposing (and would be happy to develop):
>  * A new interface, HBaseAdminInterface, that captures the signatures of the API (HBaseAdmin will implement this interface)
>  * A new method, HConnection.getHBaseAdmin(), that returns an instance of the interface


--
This message was sent by Atlassian JIRA
(v6.2#6252)