Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 15 Apr 2014 06:36:15 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12703863.1395878113861.115657.1397543775392@arcas>
In-Reply-To: <JIRA.12703863.1395878113861@arcas>
References: <JIRA.12703863.1395878113861@arcas>
Subject: [jira] [Commented] (HBASE-10845) Memstore snapshot size isn't
 updated in DefaultMemStore#rollback()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969264#comment-13969264 ] 

stack commented on HBASE-10845:
-------------------------------

[~ted_yu] Not what I was thinking but its a test... +1 (I was thinking you'd just do mock up in TestDefaultMemStore -- it already has a bunch of these kind of size calculations).

It looks like trunk already has this fix since HBASE-10648.  It was just not backported?

Thanks.

> Memstore snapshot size isn't updated in DefaultMemStore#rollback()
> ------------------------------------------------------------------
>
>                 Key: HBASE-10845
>                 URL: https://issues.apache.org/jira/browse/HBASE-10845
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
>         Attachments: 10845-0.98.txt, 10845-v1.txt, 10845-v2.txt, 10845-v3.txt, 10845-v4.txt
>
>
> In DefaultMemStore#rollback() :
> {code}
>      if (found != null && found.getMvccVersion() == kv.getMvccVersion()) {
>        this.snapshot.remove(kv);
>      }
> {code}
> this.snapshotSize should be updated in case of rollback.


--
This message was sent by Atlassian JIRA
(v6.2#6252)