Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5521106FA for ; Sun, 6 Apr 2014 05:31:31 +0000 (UTC) Received: (qmail 70944 invoked by uid 500); 6 Apr 2014 05:31:31 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 70652 invoked by uid 500); 6 Apr 2014 05:31:29 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 70598 invoked by uid 99); 6 Apr 2014 05:31:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Apr 2014 05:31:25 +0000 Date: Sun, 6 Apr 2014 05:31:25 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8963) Add configuration option to skip HFile archiving MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961337#comment-13961337 ] Ted Yu commented on HBASE-8963: ------------------------------- Please keep line length at 100 or shorter. {code} + setValue(SKIP_ARCHIVE_KEY,skip?TRUE:FALSE); {code} nit: insert space following comma, around question mark and colon. {code} + FileStatus currentStatus = fs.getFileStatus(currentFile.getPath()); + + if(conf.getBoolean(HFILE_SKIP_ARCHIVE_CONF_KEY, true) || ((htd != null) && htd.isSkipArchiveEnabled())){ {code} currentStatus is only used within the if block - you can move it inside the if block. {code} + if(fs.delete(currentFile.getPath())){ {code} Please insert space between if and '(' - applies to other if statements in patch. {code} + final HTable t = new HTable(UTIL.getConfiguration(), TEST_TABLE); {code} Where is t closed ? > Add configuration option to skip HFile archiving > ------------------------------------------------ > > Key: HBASE-8963 > URL: https://issues.apache.org/jira/browse/HBASE-8963 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: bharath v > Fix For: 0.99.0 > > Attachments: HBASE-8963.trunk.v1.patch, HBASE-8963.trunk.v2.patch, HBASE-8963.trunk.v3.patch, HBASE-8963.trunk.v4.patch, HBASE-8963.trunk.v5.patch, HBASE-8963.trunk.v6.patch, HBASE-8963.trunk.v7.patch, HBASE-8963.trunk.v8.patch > > > Currently HFileArchiver is always called when a table is dropped. > A configuration option (either global or per table) should be provided so that archiving can be skipped when table is deleted. -- This message was sent by Atlassian JIRA (v6.2#6252)