hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11093) FilterList#filterRow() iterates through its filters even though FilterList#hasFilterRow() returns false
Date Tue, 29 Apr 2014 22:15:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984893#comment-13984893
] 

stack commented on HBASE-11093:
-------------------------------

[~ted_yu] Yeah.  I think I get it.  The takeaway seems to be lets do busy work until 1.0 on
trivial issues -- this should be trivial priority, right?  Do you have numbers on savings
this code change makes -- that sucks in FOUR reviewers for a patch over code that should really
be removed (IIUC).

> FilterList#filterRow() iterates through its filters even though FilterList#hasFilterRow()
returns false
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11093
>                 URL: https://issues.apache.org/jira/browse/HBASE-11093
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 11093-v1.txt, 11093-v2.txt, 11093-v3.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of constituent filters
return false.
> However, FilterList#filterRow() still iterates through its filters in this scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message