hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11093) FilterList#filterRow() iterates through its filters even though FilterList#hasFilterRow() returns false
Date Tue, 29 Apr 2014 05:15:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984018#comment-13984018
] 

Ted Yu commented on HBASE-11093:
--------------------------------

bq. Checking for one filter.hasFilterRow() is enough to return true?
Yes. This logic was there prior to patch:
{code}
-      if(filter.hasFilterRow()) {
-     return true;
+      if (filter.hasFilterRow()) {
+        hasFilterRow = true;
+        break;
{code}
bq. Any reason for Object Boolean rather than primitive?
Boolean can express the initial status of null.

> FilterList#filterRow() iterates through its filters even though FilterList#hasFilterRow()
returns false
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11093
>                 URL: https://issues.apache.org/jira/browse/HBASE-11093
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 11093-v1.txt
>
>
> FilterList#hasFilterRow() returns false when hasFilterRow() of all of constituent filters
return false.
> However, FilterList#filterRow() still iterates through its filters in this scenario.
> The iteration should be skipped when FilterList#hasFilterRow() returns false.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message