hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11082) Potential unclosed TraceScope in FSHLog#replaceWriter()
Date Mon, 28 Apr 2014 16:26:18 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nick Dimiduk updated HBASE-11082:
---------------------------------

    Attachment: HBASE-11082.00.patch

Nice catch [~yuzhihong@gmail.com]. How does this look?

> Potential unclosed TraceScope in FSHLog#replaceWriter()
> -------------------------------------------------------
>
>                 Key: HBASE-11082
>                 URL: https://issues.apache.org/jira/browse/HBASE-11082
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Ted Yu
>            Assignee: Rekha Joshi
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11082.00.patch
>
>
> In the finally block starting at line 924:
> {code}
>     } finally {
>       // Let the writer thread go regardless, whether error or not.
>       if (zigzagLatch != null) {
>         zigzagLatch.releaseSafePoint();
>         // It will be null if we failed our wait on safe point above.
>         if (syncFuture != null) blockOnSync(syncFuture);
>       }
>       scope.close();
> {code}
> If blockOnSync() throws IOException, the TraceScope would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message