hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-11077) [AccessController] Restore compatible early-out access denial
Date Wed, 30 Apr 2014 17:10:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985752#comment-13985752
] 

Andrew Purtell edited comment on HBASE-11077 at 4/30/14 5:08 PM:
-----------------------------------------------------------------

bq. Why undo these as static finals?

As far as I know all constants in an interface are static final by default. If that is wrong
I will put them back. 

{quote}
+ String EXEC_PERMISSION_CHECKS_KEY = "hbase.security.exec.permission.checks";
What is default for the above?
{quote}
Defined right below it, but this was not introduced by this patch. It shows up in the diff
because of the unnecessary keyword removals I made. I could leave out that minor cleanup to
reduce noise. ?

{quote}
You want to do this before commit?
{code}
// XXX: Compare in place, don't clone
{code}
{quote}
We don't have API for it in the AccessController. Many changes in many places will be required.
I think this is in scope of HBASE-7123




was (Author: apurtell):
bq. Why undo these as static finals?

All constants in an interface are static final. 

{quote}
+ String EXEC_PERMISSION_CHECKS_KEY = "hbase.security.exec.permission.checks";
What is default for the above?
{quote}
Defined right below it, but this was not introduced by this patch. It shows up in the diff
because of the unnecessary keyword removals I made. I could leave out that minor cleanup to
reduce noise. ?

{quote}
You want to do this before commit?
{code}
// XXX: Compare in place, don't clone
{code}
{quote}
We don't have API for it in the AccessController. Many changes in many places will be required.
I think this is in scope of HBASE-7123



> [AccessController] Restore compatible early-out access denial
> -------------------------------------------------------------
>
>                 Key: HBASE-11077
>                 URL: https://issues.apache.org/jira/browse/HBASE-11077
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-11077.patch, HBASE-11077.patch, HBASE-11077.patch
>
>
> See parent for the whole story.
> For 0.98, to start, just put back the early out that was removed in 0.98.0 and allow
it to be overridden with a table attribute. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message