hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11061) Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
Date Thu, 24 Apr 2014 23:15:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980463#comment-13980463
] 

stack commented on HBASE-11061:
-------------------------------

So, we always get the hadoop1 'implementation':

+  /**
+   * Get the default permission for file.
+   * This is the same method as FsPermission.getFileDefault() in Hadoop 2.
+   * We provide the method here to support compatibility with Hadoop 1.
+   */
+  public static FsPermission getFileDefault() {
+    return new FsPermission((short)00666);
   }

Should this be using the hadoop-compat modules in hbase?  i.e. add this default to the hadoop1
implementation but if we are running on hadoop2, we pick up the hadoop2 implementation?

Is the method name from hadoop?  Seems like it should be getFileDefaultPermission... but if
from hadoop you can't change it.
Thanks.




> Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
> -------------------------------------------------------------
>
>                 Key: HBASE-11061
>                 URL: https://issues.apache.org/jira/browse/HBASE-11061
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jerry He
>         Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch
>
>
> HBASE-10948 fixed the issue where hbase table files all have 'x' mode.
> This JIRA is to port the fix to 0.96 / 0.98 branches.
> The port doesn't rely on API specific to hadoop 2.0



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message