hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rekha Joshi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11034) Get path validates column families twice
Date Tue, 29 Apr 2014 09:47:17 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rekha Joshi updated HBASE-11034:

    Attachment: HBASE-11034.1.patch

Attached patch.Not so for to applying it though, as checkFamily is a defensive check, and
good practice.

Also the guard condition on checkFamily() and prepareScanner() are exact opposite, this patch
should only be applied if we are very sure the scan.hasFamilies() is ALWAYS false when prepareScan
is initiated.

> Get path validates column families twice
> ----------------------------------------
>                 Key: HBASE-11034
>                 URL: https://issues.apache.org/jira/browse/HBASE-11034
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.98.0
>            Reporter: Nick Dimiduk
>            Assignee: Rekha Joshi
>            Priority: Minor
>         Attachments: HBASE-11034.1.patch
> HRegion#get(Get) adds/validates column families. The resulting RegionScanner goes through
the same validation dance a second time. That second implementation is slightly less efficient,
always checking the families, even if there were no user-provided families and the prepareScanner()
call already did this. The current logic in HRegion#get() is smarter actually. Let's do the
work only once.

This message was sent by Atlassian JIRA

View raw message