hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11025) Infrastructure for pluggable consensus service
Date Tue, 22 Apr 2014 03:16:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976339#comment-13976339
] 

Mikhail Antonov commented on HBASE-11025:
-----------------------------------------

Thanks for review [~stack] !

bq. Do we need to stop the consensus provider shutting down the Master or RegionServer?
Stopping consensus provider should handle things like quorum membership change depending on
the impl, so ZK provider (at least for now) shouldn't have to do anything, but I'm certain
we need to receive callback when server shuts down.

bq. You need it committed Mikhail Antonov to make progress?
That would be very good as without it all other patches have to carry this portion of code,
which makes them bigger than they need to be. Totally agree that having more opinions/reviews
would be good.

bq. HRS is a main entry point referenced not only in java code but in lots of scripts; changing
its constructor, it will be hard to ensure all references have also been changed.

True, I made a changes in quite a few places (including HRS commanline runner, test util classes
and actual tests) and got all tests (those which hadoop-qa runs on patch submission) passing,
but I'm not sure that it covers 100% of possible places where this constructor may be invoked
(ruby scripts?..something else?).

> Infrastructure for pluggable consensus service
> ----------------------------------------------
>
>                 Key: HBASE-11025
>                 URL: https://issues.apache.org/jira/browse/HBASE-11025
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Zookeeper
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>         Attachments: HBASE-11025(add param in HRS ctor).patch, HBASE-11025(add param
in HRS ctor).patch, HBASE-11025.patch
>
>
> Related to HBASE-10915.
> In this jira I will extract the changed for property changes, factory and consensus provider
interface (+ZK implementation), as it's going to be required by other subtasks of HBASE-10909.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message