hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11011) Avoid extra getFileStatus() calls on Region startup
Date Thu, 17 Apr 2014 21:13:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973419#comment-13973419
] 

Jean-Daniel Cryans commented on HBASE-11011:
--------------------------------------------

Does the changed code in completeCompactionMarker require a unit test? Or is there already
one?

Also fix those lines:

{quote}
+    // If we scan the directory and the file is not present, may means:
+    // so, we can't do anything with the "compaction output list" since or is
+    // already loaded on startup, because in the store folder, or it may be not
{quote}

> Avoid extra getFileStatus() calls on Region startup
> ---------------------------------------------------
>
>                 Key: HBASE-11011
>                 URL: https://issues.apache.org/jira/browse/HBASE-11011
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.96.2, 0.98.1, 1.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 1.0.0, 0.98.2, 0.96.3
>
>         Attachments: HBASE-11011-v0.patch, HBASE-11011-v1.patch
>
>
> On load we already have a StoreFileInfo and we create it from the path,
> this will result in an extra fs.getFileStatus() call.
> In completeCompactionMarker() we do a fs.exists() and later a fs.getFileStatus()
> to create the StoreFileInfo, we can avoid the exists.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message