hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11007) BLOCKCACHE in schema descriptor seems not aptly named
Date Wed, 16 Apr 2014 23:52:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972110#comment-13972110

Lars Hofhansl commented on HBASE-11007:

There's TestForceCacheImportantBlocks, which seems to test that... At least in 0.94.

The test exists in trunk, however it looks like the test is not actually verifying anything
anymore. :(
[~stack], [~apurtell], FYI. Looks like the test should either be fixed to verify something
or be removed.

> BLOCKCACHE in schema descriptor seems not aptly named
> -----------------------------------------------------
>                 Key: HBASE-11007
>                 URL: https://issues.apache.org/jira/browse/HBASE-11007
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.18
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>            Priority: Minor
> Hi,
> It seems that setting BLOCKCACHE key to false will disable the Data blocks from being
cached but will continue to cache bloom and index blocks. This same property seems to be called
cacheDataOnRead inside CacheConfig.
> Should this be called CACHE_DATA_ON_READ instead of BLOCKCACHE similar to the other CACHE_DATA_ON_WRITE/CACHE_INDEX_ON_WRITE.
We got quite confused and ended up adding our own property CACHE_DATA_ON_READ - we also added
some unit tests for the same.
> What do folks think about this ?
> Thanks
> Varun

This message was sent by Atlassian JIRA

View raw message