hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10995) Fix resource leak related to unclosed HBaseAdmin
Date Wed, 16 Apr 2014 05:16:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970437#comment-13970437
] 

Ted Yu commented on HBASE-10995:
--------------------------------

See implementation for deleteConnection():
{code}
  private static void deleteConnection(HConnectionKey connectionKey, boolean staleConnection)
{
    synchronized (CONNECTION_INSTANCES) {
      HConnectionImplementation connection = CONNECTION_INSTANCES.get(connectionKey);
      if (connection != null) {
        connection.decCount();
{code}
I don't see a problem if deleteConnection() is called twice.

> Fix resource leak related to unclosed HBaseAdmin
> ------------------------------------------------
>
>                 Key: HBASE-10995
>                 URL: https://issues.apache.org/jira/browse/HBASE-10995
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 10995-v1.txt
>
>
> This issue fixes 3 cases where HBaseAdmin is left not closed.
> Here are the files involved:
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message