hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10988) Properly wait for server in TestThriftServerCmdLine
Date Thu, 17 Apr 2014 03:58:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972282#comment-13972282
] 

Hudson commented on HBASE-10988:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #5091 (See [https://builds.apache.org/job/HBase-TRUNK/5091/])
HBASE-10988 Addendum, break long line. (larsh: rev 1588018)
* /hbase/trunk/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
HBASE-10988 Properly wait for server in TestThriftServerCmdLine. (larsh: rev 1588016)
* /hbase/trunk/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java


> Properly wait for server in TestThriftServerCmdLine
> ---------------------------------------------------
>
>                 Key: HBASE-10988
>                 URL: https://issues.apache.org/jira/browse/HBASE-10988
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
>         Attachments: 10988-0.94.txt, 10988-trunk.txt
>
>
> In 0.94 I find:
> {{Threads.sleepWithoutInterrupt(2000)}}
> In trunk I see:
> {code}
>      while ( thriftServer.serverRunner == null || thriftServer.serverRunner.tserver ==
null ){
>        Thread.sleep(1);
>      }
> {code}
> Both aren't good.
> The 0.94 version will fail if the server does not come up within 2s. The trunk version
(1) might wait forever and cause a long timeout for the test and (2) wait quite busily with
only 1ms of sleeping.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message