hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10970) [AccessController] delete latest version should check covering permission for the latest version only
Date Wed, 23 Apr 2014 08:07:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977959#comment-13977959
] 

Anoop Sam John commented on HBASE-10970:
----------------------------------------

bq.But I still feel atleast for Put doing get with max versions and then checking for the
change of col/family is bit overkill when the system has lot of versions.
We get until a match happens.  The TR for the Get is 0-maxTS . So I dont think set maxVersion(1)
will make a diff.
bq.May be we can refactor this to if/else where if deals with DELETE type and else with Put.
For Delete case also CellUtil.matchingQualifier check should be there.
col.getQualifierLength() == 0 && request == OpType.DELETE  -> This is a special
case handling with delete CF.  So not getting what is the adv with any such refactor.

> [AccessController] delete latest version should check covering permission for the latest
 version only
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10970
>                 URL: https://issues.apache.org/jira/browse/HBASE-10970
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-10970.patch
>
>
> Refer to discussion in HBASE-10823.
> bq.The exact version deletion also check for the preceeding version though the latest
version allows the permission



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message