hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10968) Null check in TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is redundant
Date Sat, 12 Apr 2014 01:57:14 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HBASE-10968:
---------------------------

       Resolution: Fixed
    Fix Version/s: 0.99.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks for the review, Matteo.

> Null check in TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is
redundant
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10968
>                 URL: https://issues.apache.org/jira/browse/HBASE-10968
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 10968-v1.txt
>
>
> Here is related code:
> {code}
>     public void initialize(InputSplit split, TaskAttemptContext context) throws IOException,
>         InterruptedException {
>       Configuration conf = context.getConfiguration();
> ...
>       if (context != null) {
>         this.context = context;
>         getCounter = TableRecordReaderImpl.retrieveGetCounterWithStringsParams(context);
>       }
> {code}
> context was dereferenced first, leaving the null check ineffective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message