hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10965) Automate detection of presence of Filter#filterRow()
Date Sat, 12 Apr 2014 03:46:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967380#comment-13967380
] 

Anoop Sam John commented on HBASE-10965:
----------------------------------------

We need similar change here also.
HRegion#nextInternal(List<Cell> results, int limit)
{code}
if (this.filter != null && filter.hasFilterRow()) {
  throw new IncompatibleFilterException(
      "Filter whose hasFilterRow() returns true is incompatible with scan with limit!");
}
{code}
Also we rely on this hasFilterRow() in other places too.  There also some changes needed?

Why is the change in FilterList?  IMO in FilterList we have to decide based on individual
filters within it.  We can not return true directly.


> Automate detection of presence of Filter#filterRow()
> ----------------------------------------------------
>
>                 Key: HBASE-10965
>                 URL: https://issues.apache.org/jira/browse/HBASE-10965
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 10965-v1.txt, 10965-v2.txt
>
>
> There is potential inconsistency between the return value of Filter#hasFilterRow() and
presence of Filter#filterRow().
> Filters may override Filter#filterRow() while leaving return value of Filter#hasFilterRow()
being false (inherited from FilterBase).
> This JIRA aims to remove the inconsistency by automatically detecting the presence of
overridden Filter#filterRow().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message