hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Zhong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10922) Log splitting status should always be closed
Date Tue, 08 Apr 2014 00:34:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962444#comment-13962444
] 

Jeffrey Zhong commented on HBASE-10922:
---------------------------------------

Good findings! You should post the full log so that I could have spotted it earlier:-).  Since
you'll touch this code, I saw below code in the same function. In which case, we will call
markComplete twice(plus the one in finally block). I think we should remove this markComplete
call and add more status info into the markComplete in the finally block. Thanks.

{code}
      if (in == null) {
        status.markComplete("Was nothing to split in log file");
        LOG.warn("Nothing to split in log file " + logPath);
        return true;
      }
{code}



> Log splitting status should always be closed
> --------------------------------------------
>
>                 Key: HBASE-10922
>                 URL: https://issues.apache.org/jira/browse/HBASE-10922
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: log-splitting_hang.png, master-log-grep.txt
>
>
> With distributed log replay enabled by default, I ran into an issue that log splitting
hasn't completed after 13 hours. It seems to hang somewhere.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message