hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10845) Memstore snapshot size isn't updated in DefaultMemStore#rollback()
Date Sun, 13 Apr 2014 05:02:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967735#comment-13967735
] 

Ted Yu commented on HBASE-10845:
--------------------------------

I started with adding test in TestHRegion by setting up a custom RegionObserver:
{code}
+    conf.set(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY,
+        BuggyRegionObserver.class.getName());
{code}
However the RegionObserver methods weren't called - RegionCoprocessorHost doesn't come into
play in the context of TestHRegion.

Let me take a look at TestCoprocessorInterface which Lars mentioned.

> Memstore snapshot size isn't updated in DefaultMemStore#rollback()
> ------------------------------------------------------------------
>
>                 Key: HBASE-10845
>                 URL: https://issues.apache.org/jira/browse/HBASE-10845
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.94.19, 0.98.2, 0.96.3
>
>         Attachments: 10845-v1.txt, 10845-v2.txt
>
>
> In DefaultMemStore#rollback() :
> {code}
>      if (found != null && found.getMvccVersion() == kv.getMvccVersion()) {
>        this.snapshot.remove(kv);
>      }
> {code}
> this.snapshotSize should be updated in case of rollback.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message