hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10841) Scan setters should consistently return this
Date Wed, 30 Apr 2014 02:12:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985074#comment-13985074
] 

Enis Soztutar commented on HBASE-10841:
---------------------------------------

HBASE-10460 was the issue. 

Doing this would break binary BC. I think we are fine with breaking BC between 0.98 and 1.0
as long as we retain wire compat. 



> Scan setters should consistently return this
> --------------------------------------------
>
>                 Key: HBASE-10841
>                 URL: https://issues.apache.org/jira/browse/HBASE-10841
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, Usability
>    Affects Versions: 0.99.0
>            Reporter: Nick Dimiduk
>            Priority: Minor
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}} class is
inconsistent with it's setter methods. Some of them return {{this}}, other's don't. They should
be consistent. I suggest making them all return {{this}}, to support chained invocation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message