hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10251) Restore API Compat for PerformanceEvaluation.generateValue()
Date Tue, 29 Apr 2014 21:29:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984818#comment-13984818
] 

Nick Dimiduk commented on HBASE-10251:
--------------------------------------

[~apurtell] yes I recall the conversation; no I don't remember the context. I think it's a
good idea, and is on my todo list. One of the prerequisites in my mind is that we add some
unit test coverage around how the various features overlap in test configuration.

Quasi-related, I hacked it up pretty badly in HBASE-10791 for an integration test on the HBASE-10070
branch. We should consider how much code-reuse we want to make available for other tests vs
stand-alone application, where a util library class resides, etc. We already have PerformanceEvaluationCommons,
which seems like an ideal place for the functionality [~aleksshulman] is referring to.

> Restore API Compat for PerformanceEvaluation.generateValue()
> ------------------------------------------------------------
>
>                 Key: HBASE-10251
>                 URL: https://issues.apache.org/jira/browse/HBASE-10251
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0
>            Reporter: Aleksandr Shulman
>              Labels: api_compatibility
>
> Observed:
> A couple of my client tests fail to compile against trunk because the method PerformanceEvaluation.generateValue
was removed as part of HBASE-8496.
> This is an issue because it was used in a number of places, including unit tests. Since
we did not explicitly label this API as private, it's ambiguous as to whether this could/should
have been used by people writing apps against 0.96. If they used it, then they would be broken
upon upgrade to 0.98 and trunk.
> Potential Solution:
> The method was renamed to generateData, but the logic is still the same. We can reintroduce
it as deprecated in 0.98, as compat shim over generateData. The patch should be a few lines.
We may also consider doing so in trunk, but I'd be just as fine with leaving it out.
> More generally, this raises the question about what other code is in this "grey-area",
where it is public, is used outside of the package, but is not explicitly labeled with an
AudienceInterface.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message