hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9003) TableMapReduceUtil should not rely on org.apache.hadoop.util.JarFinder#getJar
Date Tue, 29 Apr 2014 04:51:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983997#comment-13983997
] 

Hadoop QA commented on HBASE-9003:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12642385/HBASE-9003.v0.patch
  against trunk revision .
  ATTACHMENT ID: 12642385

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs (version 1.3.9) to
fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9417//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9417//console

This message is automatically generated.

> TableMapReduceUtil should not rely on org.apache.hadoop.util.JarFinder#getJar
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-9003
>                 URL: https://issues.apache.org/jira/browse/HBASE-9003
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>             Fix For: 0.99.0
>
>         Attachments: HBASE-9003.v0.patch
>
>
> This is the problem: {{TableMapReduceUtil#addDependencyJars}} relies on {{org.apache.hadoop.util.JarFinder}}
if available to call {{getJar()}}. However {{getJar()}} uses File.createTempFile() to create
a temporary file under {{hadoop.tmp.dir}}{{/target/test-dir}}. Due HADOOP-9737 the created
jar and its content is not purged after the JVM is destroyed. Since most configurations point
{{hadoop.tmp.dir}} under {{/tmp}} the generated jar files get purged by {{tmpwatch}} or a
similar tool, but boxes that have {{hadoop.tmp.dir}} pointing to a different location not
monitored by {{tmpwatch}} will pile up a collection of jars causing all kind of issues. Since
{{JarFinder#getJar}} is not a public API from Hadoop (see [~tucu00] comment on HADOOP-9737)
we shouldn't use that as part of {{TableMapReduceUtil}} in order to avoid this kind of issues.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message