hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7319) Extend Cell usage through read path
Date Tue, 08 Apr 2014 05:22:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962598#comment-13962598
] 

stack commented on HBASE-7319:
------------------------------

Patch is looking good.

These seem a little strange:

   public static KeyValue createFirstOnRow(final byte [] row) {
-    return createFirstOnRow(row, HConstants.LATEST_TIMESTAMP);
+    return KeyValueUtil.createFirstOnRow(row, HConstants.LATEST_TIMESTAMP);
   }

Why not change the caller so it uses the KVU directly rather than have KV reference KVU?

Same for createFirstOnRow, etc.

I skimmed the patch.  Radical.  It looks great Ram.

> Extend Cell usage through read path
> -----------------------------------
>
>                 Key: HBASE-7319
>                 URL: https://issues.apache.org/jira/browse/HBASE-7319
>             Project: HBase
>          Issue Type: Umbrella
>          Components: Compaction, Performance, regionserver, Scanners
>            Reporter: Matt Corgan
>         Attachments: HBASE-7319.patch
>
>
> Umbrella issue for eliminating Cell copying.
> The Cell interface allows us to work with a reference to underlying bytes in the block
cache without copying each Cell into consecutive bytes in an array (KeyValue).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message