hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5697) Audit HBase for usage of deprecated hadoop 0.20.x property names.
Date Wed, 16 Apr 2014 23:24:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972082#comment-13972082
] 

Jonathan Hsieh commented on HBASE-5697:
---------------------------------------

Looks good.  From the list i think there might be a bug -- can you double check?

bq. mapred.map.max.attempts -> mapreduce.map.max.attempts  

According to the link I provided, this should be mapreduce.map.maxattempts (no '.' between
max.attempts.)

{code}
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
index 9b21f36..1957c4d 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
@@ -82,7 +82,6 @@ public class TestExportSnapshot {
     conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 6);
     conf.setBoolean("hbase.master.enabletable.roundrobin", true);
     conf.setInt("mapreduce.map.max.attempts", 10);
-    conf.setInt("mapred.map.max.attempts", 10);
   }
{code}

Did you grep for all the ones on the page?  I'm fine with committing this but file a follow
on to check the rest. 

> Audit HBase for usage of deprecated hadoop 0.20.x property names.
> -----------------------------------------------------------------
>
>                 Key: HBASE-5697
>                 URL: https://issues.apache.org/jira/browse/HBASE-5697
>             Project: HBase
>          Issue Type: Task
>            Reporter: Jonathan Hsieh
>            Assignee: Srikanth Srungarapu
>              Labels: noob
>         Attachments: HBASE-5697.patch, deprecated_properties
>
>
> Many xml config properties in Hadoop have changed in 0.23.  We should audit hbase to
insulate it from hadoop property name changes.
> Here is a list of the hadoop property name changes:
> http://hadoop.apache.org/common/docs/r0.23.1/hadoop-project-dist/hadoop-common/DeprecatedProperties.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message