Return-Path: 
 <issues-return-141520-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9414D107EF
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sat, 29 Mar 2014 10:09:17 +0000 (UTC)
Received: (qmail 64887 invoked by uid 500); 29 Mar 2014 10:09:16 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 64843 invoked by uid 500); 29 Mar 2014 10:09:15 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 64826 invoked by uid 99); 29 Mar 2014 10:09:15 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Mar 2014 10:09:15 +0000
Date: Sat, 29 Mar 2014 10:09:14 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12704218.1396003548186.29808.1396087754921@arcas>
In-Reply-To: <JIRA.12704218.1396003548186@arcas>
References: <JIRA.12704218.1396003548186@arcas>
Subject: [jira] [Commented] (HBASE-10860) Insufficient AccessController
 covering permission check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951825#comment-13951825 ] 

Andrew Purtell commented on HBASE-10860:
----------------------------------------

+1 patch looks good

> Insufficient AccessController covering permission check
> -------------------------------------------------------
>
>                 Key: HBASE-10860
>                 URL: https://issues.apache.org/jira/browse/HBASE-10860
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-10860.patch
>
>
> {code}
>   List<Cell> list = (List<Cell>)entry.getValue();
>   if (list == null || list.isEmpty()) {
> 	get.addFamily(col);
>   } else {
> 	for (Cell cell : list) {
> 	  get.addColumn(col, CellUtil.cloneQualifier(cell));
> 	}
>   }
> {code}
> When a delete family Mutation comes, a Cell will be added into the list with Qualifier as null. (See Delete#deleteFamily(byte[])). So it will miss getting added against the check list == null || list.isEmpty().  We will fail getting the cells under this cf for covering permission check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)