Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 25 Mar 2014 21:57:15 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12703544.1395771969744.4578.1395784635662@arcas>
In-Reply-To: <JIRA.12703544.1395771969744@arcas>
References: <JIRA.12703544.1395771969744@arcas>
Subject: [jira] [Commented] (HBASE-10829) Flush is skipped after log replay
 if the last recovered edits file is skipped
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947217#comment-13947217 ] 

Hadoop QA commented on HBASE-10829:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12636761/hbase-10829_v2.patch
  against trunk revision .
  ATTACHMENT ID: 12636761

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    {color:red}-1 findbugs{color}.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9093//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9093//console

This message is automatically generated.

> Flush is skipped after log replay if the last recovered edits file is skipped
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-10829
>                 URL: https://issues.apache.org/jira/browse/HBASE-10829
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Critical
>             Fix For: 0.99.0, 0.98.2, 0.96.3
>
>         Attachments: hbase-10829_v1.patch, hbase-10829_v2.patch
>
>
> We caught this in an extended test run where IntegrationTestBigLinkedList failed with some missing keys. 
> The problem is that HRegion.replayRecoveredEdits() would return -1 if all the edits in the log file is skipped, which is true for example if the log file only contains a single compaction record (HBASE-2231) or somehow the edits cannot be applied (column family deleted, etc). 
> The callee, HRegion.replayRecoveredEditsIfAny() only looks for the last returned seqId to decide whether a flush is necessary or not before opening the region, and discarding replayed recovered edits files. 
> Therefore, if the last recovered edits file is skipped but some edits from earlier recovered edits files are applied, the mandatory flush before opening the region is skipped. If the region server dies after this point before a flush, the edits are lost. 
> This is important to fix, though the sequence of events are super rare for a production cluster. 


--
This message was sent by Atlassian JIRA
(v6.2#6252)