Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 25 Mar 2014 03:36:17 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12703384.1395718450188.137195.1395718577039@arcas>
In-Reply-To: <JIRA.12703384.1395718450188@arcas>
References: <JIRA.12703384.1395718450188@arcas>
Subject: [jira] [Updated] (HBASE-10824) Enhance detection of protobuf
 generated code in line length check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-10824:
---------------------------

    Status: Patch Available  (was: Open)

> Enhance detection of protobuf generated code in line length check
> -----------------------------------------------------------------
>
>                 Key: HBASE-10824
>                 URL: https://issues.apache.org/jira/browse/HBASE-10824
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 10824-v1.txt
>
>
> In review of HBASE-5175, Anoop found that long line detection wasn't very effective for protobuf generated code.
> Here is one example:
> {code}
> -1 lineLengths. The patch introduces the following lines longer than 100:
> + private DoubleMsg(boolean noInit)
> { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
> {code}
> This is current filter:
> {code}
>   lines=`cat $PATCH_DIR/patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | grep -v "hbase.protobuf.generated" | awk -v len="$MAX_LINE_LENGTH_PATCH"    'length ($0) > len' | head -n 10`
> {code}
> 'com.google.protobuf.' should be considered as well.


--
This message was sent by Atlassian JIRA
(v6.2#6252)