Return-Path: 
 <issues-return-140708-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D5A0A106B9
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sat, 22 Mar 2014 00:52:56 +0000 (UTC)
Received: (qmail 20553 invoked by uid 500); 22 Mar 2014 00:52:44 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 20456 invoked by uid 500); 22 Mar 2014 00:52:43 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 20444 invoked by uid 99); 22 Mar 2014 00:52:43 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Mar 2014 00:52:43 +0000
Date: Sat, 22 Mar 2014 00:52:43 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12702998.1395446604456.122999.1395449563451@arcas>
In-Reply-To: <JIRA.12702998.1395446604456@arcas>
References: <JIRA.12702998.1395446604456@arcas>
Subject: [jira] [Updated] (HBASE-10810) LoadTestTool should share the
 connection and connection pool
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar updated HBASE-10810:
----------------------------------

    Attachment: hbase-10810_v1.patch

Here is a simple enough patch. It changes new HTable()'s with HConnection.getTable() calls. 

I've tested this with LTT and IntegrationTestTimeBoundedRequestsWithRegionReplicas with 100 writer / reader threads. 

The number of threads during execution with CM does not exceed 410 (100 threads for readers + 256 for pool + some other). 

> LoadTestTool should share the connection and connection pool
> ------------------------------------------------------------
>
>                 Key: HBASE-10810
>                 URL: https://issues.apache.org/jira/browse/HBASE-10810
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: hbase-10070
>
>         Attachments: hbase-10810_v1.patch
>
>
> While running the IT test from HBASE-10572, we've noticed that the number of threads jumps to 4K's when CM actions are going on. 
> Our [~ndimiduk] summarizes the problem quite good: 
> MultiThreadedReader creates this pool for each HTable:
> {code}
>     ThreadPoolExecutor pool = new ThreadPoolExecutor(1, maxThreads, keepAliveTime, TimeUnit.SECONDS,
>         new SynchronousQueue<Runnable>(), Threads.newDaemonThreadFactory("htable"));
> {code}
> This comes from the HTable creation
> {code}  
> public HTable(Configuration conf, final TableName tableName)
> {code}
> As well the javadoc says Recommended.
> This is wrong.
> In this issue we can change the LTT sub classes to use the shared connection object and initialize their tables using HConnection.getTable() rather than new HTable(). 
> This is relevant to trunk as well, but there since there is only one outstanding RPC per thread, it is not such a big problem. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)