Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2051610388 for ; Mon, 17 Mar 2014 04:57:47 +0000 (UTC) Received: (qmail 94558 invoked by uid 500); 17 Mar 2014 04:57:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 94267 invoked by uid 500); 17 Mar 2014 04:57:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 94254 invoked by uid 99); 17 Mar 2014 04:57:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2014 04:57:42 +0000 Date: Mon, 17 Mar 2014 04:57:42 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10755) MutableHistogram is capitalizing the metric names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937457#comment-13937457 ] stack commented on HBASE-10755: ------------------------------- [~jdcryans] You have the simple fix? Lets just commit. I think I was looking at this over last few days and just didn't 'see' why some metrics were showing further down in the page. Thanks boss. > MutableHistogram is capitalizing the metric names > ------------------------------------------------- > > Key: HBASE-10755 > URL: https://issues.apache.org/jira/browse/HBASE-10755 > Project: HBase > Issue Type: Bug > Affects Versions: 0.96.0 > Reporter: Jean-Daniel Cryans > Priority: Minor > > Noticed something while looking at MBeans; some metric names are capitalized while others aren't. This has the unwanted property of changing the metric names sorting. For example: > Namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_scanNext_num_ops > namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_appendCount > The reason for this is that {{MutableHistogram}} uses {{StringUtils.capitalize()}} on the metrics name (as create by {{MetricsRegionSourceImpl}} with "namespace_"). > I'm not sure what the intent was with capitalization, but either way it's a simple fix. [~eclark]? -- This message was sent by Atlassian JIRA (v6.2#6252)