Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 270AD10F89 for ; Tue, 11 Mar 2014 06:11:45 +0000 (UTC) Received: (qmail 23289 invoked by uid 500); 11 Mar 2014 06:11:44 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 23145 invoked by uid 500); 11 Mar 2014 06:11:43 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 23133 invoked by uid 99); 11 Mar 2014 06:11:43 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2014 06:11:43 +0000 Date: Tue, 11 Mar 2014 06:11:43 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10718) TestHLogSplit fails when it sets a KV size to be negative MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930001#comment-13930001 ] Hadoop QA commented on HBASE-10718: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633843/HBASE-10718.v1.txt against trunk revision . ATTACHMENT ID: 12633843 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + Bytes.toBytes("myQualifier"), 12345L, Bytes.toBytes("my12345")); // 51 bytes + Bytes.toBytes("myQualifier"), 12345L, Bytes.toBytes("my123")); // 49 bytes {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8946//console This message is automatically generated. > TestHLogSplit fails when it sets a KV size to be negative > --------------------------------------------------------- > > Key: HBASE-10718 > URL: https://issues.apache.org/jira/browse/HBASE-10718 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 0.98.0, 0.99.0, 0.96.1.1, 0.94.17 > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Attachments: HBASE-10718.v0.txt, HBASE-10718.v1.txt, HBASE-10718.v2.txt, HBASE-10718.v3.txt > > > From [~jdcryans]: > {code} > java.lang.NegativeArraySizeException > at org.apache.hadoop.hbase.KeyValue.readFields(KeyValue.java:2259) > at org.apache.hadoop.hbase.KeyValue.readFields(KeyValue.java:2266) > at org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder.parseCell(KeyValueCodec.java:64) > at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:46) > at org.apache.hadoop.hbase.regionserver.wal.WALEdit.readFields(WALEdit.java:222) > at org.apache.hadoop.io.SequenceFile$Reader.getCurrentValue(SequenceFile.java:2114) > at org.apache.hadoop.io.SequenceFile$Reader.next(SequenceFile.java:2242) > at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.next(SequenceFileLogReader.java:245) > at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.next(SequenceFileLogReader.java:214) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.getNextLogLine(HLogSplitter.java:799) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.parseHLog(HLogSplitter.java:727) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:307) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:217) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:180) > at org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit.testMiddleGarbageCorruptionSkipErrorsReadsHalfOfFile(TestHLogSplit.java:363) > ... > {code} > It seems to me that we're reading a negative length which we use to create the byte array and since it's not an IOE we don't treat it as a corrupted log. I'm surprised that not a single build has failed like this in the past 3 years. -- This message was sent by Atlassian JIRA (v6.2#6252)