Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C82C10BE4 for ; Tue, 11 Mar 2014 03:14:49 +0000 (UTC) Received: (qmail 15871 invoked by uid 500); 11 Mar 2014 03:14:48 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 15815 invoked by uid 500); 11 Mar 2014 03:14:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15795 invoked by uid 99); 11 Mar 2014 03:14:43 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2014 03:14:43 +0000 Date: Tue, 11 Mar 2014 03:14:43 +0000 (UTC) From: "Esteban Gutierrez (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10718) TestHLogSplit fails when it sets a KV size to be negative MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esteban Gutierrez updated HBASE-10718: -------------------------------------- Attachment: HBASE-10718.v1.txt New patch that includes suggestions from [~jmhsieh] and [~yuzhihong@gmail.com] Thanks! > TestHLogSplit fails when it sets a KV size to be negative > --------------------------------------------------------- > > Key: HBASE-10718 > URL: https://issues.apache.org/jira/browse/HBASE-10718 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 0.98.0, 0.99.0, 0.96.1.1, 0.94.17 > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Attachments: HBASE-10718.v0.txt, HBASE-10718.v1.txt > > > From [~jdcryans]: > {code} > java.lang.NegativeArraySizeException > at org.apache.hadoop.hbase.KeyValue.readFields(KeyValue.java:2259) > at org.apache.hadoop.hbase.KeyValue.readFields(KeyValue.java:2266) > at org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueDecoder.parseCell(KeyValueCodec.java:64) > at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:46) > at org.apache.hadoop.hbase.regionserver.wal.WALEdit.readFields(WALEdit.java:222) > at org.apache.hadoop.io.SequenceFile$Reader.getCurrentValue(SequenceFile.java:2114) > at org.apache.hadoop.io.SequenceFile$Reader.next(SequenceFile.java:2242) > at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.next(SequenceFileLogReader.java:245) > at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.next(SequenceFileLogReader.java:214) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.getNextLogLine(HLogSplitter.java:799) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.parseHLog(HLogSplitter.java:727) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:307) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:217) > at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLog(HLogSplitter.java:180) > at org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit.testMiddleGarbageCorruptionSkipErrorsReadsHalfOfFile(TestHLogSplit.java:363) > ... > {code} > It seems to me that we're reading a negative length which we use to create the byte array and since it's not an IOE we don't treat it as a corrupted log. I'm surprised that not a single build has failed like this in the past 3 years. -- This message was sent by Atlassian JIRA (v6.2#6252)