Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD1A310801 for ; Mon, 10 Mar 2014 20:12:45 +0000 (UTC) Received: (qmail 9067 invoked by uid 500); 10 Mar 2014 20:12:44 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9029 invoked by uid 500); 10 Mar 2014 20:12:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 8952 invoked by uid 99); 10 Mar 2014 20:12:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Mar 2014 20:12:44 +0000 Date: Mon, 10 Mar 2014 20:12:44 +0000 (UTC) From: "Jimmy Xiang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10714) SyncFuture hangs when sequence is 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated HBASE-10714: -------------------------------- Status: Open (was: Patch Available) > SyncFuture hangs when sequence is 0 > ----------------------------------- > > Key: HBASE-10714 > URL: https://issues.apache.org/jira/browse/HBASE-10714 > Project: HBase > Issue Type: Bug > Components: wal > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Fix For: 0.99.0 > > Attachments: hbase-10714.patch > > > In SyncFuture, NOT_DONE = 0. The initial value of the ringBuffer is -1. So ringBuffer.next() gives 0 for the first call. If we create a SyncFuture with sequence = 0, even when we set it's done (ie. doneSequence = 0), it is still not done since doneSequence == NOT_DONE == 0. Can we set NOT_DONE to -1, and the initial doneSequence to -2? -- This message was sent by Atlassian JIRA (v6.2#6252)