Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8264B10261 for ; Fri, 14 Mar 2014 01:11:55 +0000 (UTC) Received: (qmail 1824 invoked by uid 500); 14 Mar 2014 01:11:50 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 1683 invoked by uid 500); 14 Mar 2014 01:11:48 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 1614 invoked by uid 99); 14 Mar 2014 01:11:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Mar 2014 01:11:47 +0000 Date: Fri, 14 Mar 2014 01:11:47 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10599) Replace System.currentMillis() with EnvironmentEdge.currentTimeMillis in memstore flusher and related places MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934400#comment-13934400 ] Andrew Purtell commented on HBASE-10599: ---------------------------------------- Hmm, ok well on the premise this can help our (possibly future) testability, I will commit this shortly only to trunk unless objection. > Replace System.currentMillis() with EnvironmentEdge.currentTimeMillis in memstore flusher and related places > ------------------------------------------------------------------------------------------------------------ > > Key: HBASE-10599 > URL: https://issues.apache.org/jira/browse/HBASE-10599 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 0.96.2, 0.98.1, 0.99.0 > > Attachments: HBASE-10599.patch > > > Memstoreflusher still uses System.currentMillis. Better to replace it with EnvironmentEdge.currentMillis(), -- This message was sent by Atlassian JIRA (v6.2#6252)