Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA340104A9 for ; Thu, 13 Mar 2014 03:04:47 +0000 (UTC) Received: (qmail 86640 invoked by uid 500); 13 Mar 2014 03:04:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 86444 invoked by uid 500); 13 Mar 2014 03:04:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86426 invoked by uid 99); 13 Mar 2014 03:04:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Mar 2014 03:04:44 +0000 Date: Thu, 13 Mar 2014 03:04:44 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10514) Forward port HBASE-10466, possible data loss when failed flushes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932832#comment-13932832 ] Anoop Sam John commented on HBASE-10514: ---------------------------------------- Oh.. whatever doubt was there in my mind seems not an issue.. Reading these lines {code} synchronized (writestate) { // Disable compacting and flushing by background threads for this // region. writestate.writesEnabled = false; LOG.debug("Closing " + this + ": disabling compactions & flushes"); waitForFlushesAndCompactions(); } // If we were not just flushing, is it worth doing a preflush...one // that will clear out of the bulk of the memstore before we put up // the close flag? if (!abort && worthPreFlushing()) { {code} > Forward port HBASE-10466, possible data loss when failed flushes > ---------------------------------------------------------------- > > Key: HBASE-10514 > URL: https://issues.apache.org/jira/browse/HBASE-10514 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: stack > Priority: Critical > Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.18 > > Attachments: 10514.txt, 10514v2.txt, 10514v3.txt, 10514v3.txt, 10514v4.txt > > > Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself. -- This message was sent by Atlassian JIRA (v6.2#6252)