hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10860) Insufficient AccessController covering permission check
Date Fri, 28 Mar 2014 11:23:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950588#comment-13950588
] 

ramkrishna.s.vasudevan commented on HBASE-10860:
------------------------------------------------

so we will get an exception here?
{code}
get.addColumn(col, CellUtil.cloneQualifier(cell));
{code}
Because the cell has null qualifier? Patch looks good anyway. +1

> Insufficient AccessController covering permission check
> -------------------------------------------------------
>
>                 Key: HBASE-10860
>                 URL: https://issues.apache.org/jira/browse/HBASE-10860
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 0.99.0, 0.98.2
>
>         Attachments: HBASE-10860.patch
>
>
> {code}
>   List<Cell> list = (List<Cell>)entry.getValue();
>   if (list == null || list.isEmpty()) {
> 	get.addFamily(col);
>   } else {
> 	for (Cell cell : list) {
> 	  get.addColumn(col, CellUtil.cloneQualifier(cell));
> 	}
>   }
> {code}
> When a delete family Mutation comes, a Cell will be added into the list with Qualifier
as null. (See Delete#deleteFamily(byte[])). So it will miss getting added against the check
list == null || list.isEmpty().  We will fail getting the cells under this cf for covering
permission check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message